Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace ParticleSmearing with TrackParameterSmearing in Examples #3784

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

refactor: Replace ParticleSmearing with TrackParameterSmearing in Examples #3784

wants to merge 14 commits into from

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Oct 25, 2024 •
edited
Loading

  • extract track parameters from particles
  • replace ParticleSmearing with TrackParameterSmearing

@andiwand andiwand added this to the next milestone Oct 25, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Oct 25, 2024
@andiwand andiwand changed the title refactor: Replace particle smearing by track parameter smearing in Examples refactor: Replace ParticleSmearing with TrackParameterSmearing in Examples Oct 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

📊: Physics performance monitoring for eca524c

Full contents

physmon summary

@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Oct 28, 2024
paulgessinger
paulgessinger reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the idea is that we just produce full in track parameters and update the smearing to run in track parameters?

Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TrackParameterSmearing.cpp Show resolved Hide resolved
Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TrackParameterSmearing.cpp Show resolved Hide resolved
@andiwand
Copy link
Contributor Author

andiwand commented Nov 2, 2024

I think smearing track parameters is more general than smearing particles to tracks. I enabled the generator to distribute true track parameters which can also be used for other stuff than smearing. I saw a couple of times that we disable the smearing with 0 sigmas which can now be purely handled by the generator.

@andiwand
Copy link
Contributor Author

andiwand commented Nov 2, 2024

Actually to make this work correctly I have to extract the track parameters from particles in a different spot. Right now the track parameters and truth proto tracks do not reliably align anymore. To solve it it makes more sense to have a separate extraction algorithm I believe.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Nov 6, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 6, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@andiwand andiwand changed the title refactor: Replace ParticleSmearing with TrackParameterSmearing in Examples refactor: Replace ParticleSmearing with TrackParameterSmearing in Examples Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger left review comments

Assignees
No one assigned
Labels
Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
2 participants
@andiwand @paulgessinger